update TODO

1 files changed, 31 insertions, 9 deletions

diff --git a/TODO b/TODO
index 87329fd..30779b1 100644
--- a/TODO
+++ b/TODO
@@ -5,12 +5,15 @@ Key:
     ? Not sure if it's done
 
 - write cross section section in paper
-- explain integral in paper
+? explain integral in paper
+    - not sure what integral I was talking about here. I just checked the git
+      history and this was before I had written the fitter, so it must be
+      talking about the integral to compute the expected event rate.
 p develop signal generator
     - made signal generator for two particle decays
 p develop high energy and multi-ring fitter
 ^ write talk for Monday
-- write a section on atmospheric backgrounds in paper
+^ write a section on atmospheric backgrounds in paper
 ^ check index of refraction calculation against tables in the paper
 ^ write more tests for the solid angle calculation
     - use table from paper
@@ -39,6 +42,10 @@ p add rayleigh scattering to likelihood function
 p add muon shower PDF? delta rays?
     - Done for delta rays, but need to add shower photons
 - calculate path length through acrylic?
+    - did some tests on this and it seems to fix the radial energy bias for
+      electrons, so it's definitely an issue. However, currently the small 5%
+      energy bias is not really a big deal, although I would like to fix this
+      eventually.
 p update estar table with energies above 1 GeV
     - added values up to 10 GeV
 ^ speed up normalize() and interp1d()
@@ -54,9 +61,16 @@ p calculate psi parameter as a goodness of fit test
 p optimize CHARGE_FRACTION
 ? find out why likelihood is sometimes returning nan
 ^ add pdf for cerenkov light from delta rays
-- tweak find peaks algorithm
+^ tweak find peaks algorithm
 ^ update zebra to allow use of links
-- minimum energy for each particle type
+p minimum energy for each particle type
+    - I do already have a minimum energy which is the Cerenkov threshold,
+      however I think what I meant here was to have something significantly
+      higher than that since a particle just at the Cerenkov threshold won't
+      produce many PMT hits. I think I was mostly concerned about this issue
+      because many fits were always fitting better by including a low energy
+      electron, however I have solved that problem by simply dropping multi
+      particle fits which have an electron with an energy less than 20 MeV.
 ^ check all zebra links
 ^ fix zero logical record size bug in zebra.c
 p speed up fit
@@ -81,19 +95,27 @@ p update charge code to handle highest values for qhs and qlx
 p figure out why electron energy bias is +10%
     - updated code to use a more accurate approximation for the number of
       shower photons which seems to bring the bias down to 5%
-- update find peaks algorithm to do single particle quick fits
+p update find peaks algorithm to do single particle quick fits
+    - I did update the find peaks algorithm to work *much* better, but it still
+      doesn't do single particle quick fits. I think the next improvement would
+      be to add the ability to actually determine the number of rings.
 ^ figure out how to combine SNO fitter data with my fitter for final analysis.
   For example, how to apply neutron follower cut?
 - double check that zdab-reprocess is correct for the D2O and salt phases since
   it appears to be from the NCD phase
-- add code to compute expected deviation from nll_best to normalize psi
-- add term to likelihood for probability that a channel is misccalibrated or
+? add code to compute expected deviation from nll_best to normalize psi
+    - tried several different versions of this and nothing seemed to perform as
+      well as psi/nhit.
+^ add term to likelihood for probability that a channel is misccalibrated or
   didn't make it into the event
 - when calculating the first order statistic for a gaussian is alpha = pi/8 a
   better choice than 0.375?
 - speed up charge initialization
 - determine *real* mean and standard deviation of single PE charge
   distribution. TELLIE SNO+ data?
-- extend electron range table
-- fix time PDF. Currently take the first order statistic of dark noise +
+^ extend electron range table
+    - extended the electron range table up to 1 TeV
+? fix time PDF. Currently take the first order statistic of dark noise +
   indirect light + direct light all together, but this isn't correct.
+    - thought more about this and it's not actually obvious if what I'm doing
+      is wrong. Need to think more about this.